This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BZ #12194] Fix byteswap conversion warning


On 06/20/2012 09:17 AM, Andreas Jaeger wrote:
> 
> The bugreport was closed in October 2010 - but only the x86 versions
> were fixed but not the others as noticed today.
> 
> Here's a fix for the rest. I tested the generic functions on my system.
> 
> Ok to commit?
> 
> Andreas, you might want to cleanup the s390 functions, I'm not convinced
> that the __tmp variable is needed. Could you test also the patch below,
> please?

Tested on s390x - no regressions.

The byteswap.h files probably should only use software implementations which hopefully
will be recognized by GCC and replaced with hardware instructions (GCC >= 4.5.0).

Bye,

-Andreas-


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]