This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #14134] Fix iconv segfault while converting fromIBM-930
Hi,
Is this OK to commit as obvious? I guess Petr gave an ack for the first
hunk of the earlier patch, which is what the second updated patch is
-- just the first hunk.
Thanks
Siddhesh
On Mon, 4 Jun 2012 23:52:32 +0530, Siddhesh wrote:
> On Mon, 4 Jun 2012 20:07:26 +0200, Petr wrote:
> >
> > Silly me, you are right. In that case, the first hunk of the patch
> > looks good to me. The second is AIUI still redundant?
> >
>
> Oh right, the second hunk is in fact redundant. I had added it in as
> an analogous change without a test case to prove it. I also now
> understand why you looked at the opposite conversion; sorry about
> that.
>
> Updated patch attached.
>
> Thanks,
> Siddhesh
>
> 2012-05-23 Siddhesh Poyarekar <siddhesh@redhat.com>
>
> * iconvdata/ibm930.c (BODY) [FROM_LOOP]: Check for invalid
> character 0xffff that matches the last element of the
> conversion table.