This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix ldbl128ibm fmodl for subnormals
On 06/05/2012 09:51 AM, Carlos O'Donell wrote:
> On 6/4/2012 5:56 PM, Ryan S. Arnold wrote:
>> On Mon, Jun 4, 2012 at 10:19 AM, Adhemerval Zanella
>> <azanella@linux.vnet.ibm.com> wrote:
>>> Current subnormal tests for fmod (TEST_ff_f (fmod, 0x0.fffffffffffffp-1022L, 0x1p-1074L, plus_zero))
>>> fails for ldbl-128ibm. This patch fixes it and it is related to commit 'Fix fmod for subnormals'
>>> (c5bfe3d5ba29d36563f1e4bd4f8d7336093ee6fc).
>>>
>>> Tested on ppc32 and ppc64.
>>>
>>> ---
>>>
>>> 2012-06-04 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
>>>
>>> * sysdeps/ieee754/ldbl-128ibm/e_fmodl.c (__ieee754_fmodl): Fix
>>> subnormal exponent extraction and add some __builtin_expect.
>>> * sysdeps/ieee754/ldbl-128ibm/math_ldbl.h (ldbl_extract_mantissa):
>>> Fix for subnormal mantissa calculation.
>> I'm fine with these bug fixes and would like them to go in for 2.16 if
>> it's ok with Carlos.
> These are OK with me.
>
> They improve the quality of the release and stabilize 2.16.
>
> I want to avoid superfluous cleanups, enhancements, or new features.
>
> Cheers,
> Carlos.
Pushed upstream as git commit 34ae0b3270c67cae0c54ac98b693fdf7d010a206
--
Adhemerval Zanella Netto
Software Engineer
Linux Technology Center Brazil
Toolchain / GLIBC on Power Architecture
azanella@linux.vnet.ibm.com / azanella@br.ibm.com
+55 61 8642-9890