This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 4 Jun 2012 12:42:37 -0700
Subject: Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
References: <20120604141710.GF17135@intel.com><20120604191845.2E2DD2C0AD@topped-with-meat.com>

On Mon, Jun 4, 2012 at 12:18 PM, Roland McGrath <roland@hack.frob.com> wrote:
> I don't think we should be duplicating so much code in two files. ?I
> think it's the case that we effectively require i486 or newer nowadays
> (i.e. no i386-*-* configurations really work). ?At any rate, your
> change adds the #if test so that -march=i386 wouldn't use the inlines.
> So I think what you should do is first make the change to the file in
> place to add the #if test, and then move it to sysdeps/x86.
>

I think this is exactly what my patch does.  The follow-up patch to remove
sysdeps/i386/i486/bits/string.h is at:

http://sourceware.org/ml/libc-alpha/2012-06/msg00149.html



-- 
H.J.

Follow-Ups:
- Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
  - From: Roland McGrath

References:
- [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
  - From: H.J. Lu
- Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]