This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Suppress sign-conversion warning from FD_SET
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org, yunlian at google dot com
- Date: Sun, 3 Jun 2012 17:33:10 -0700
- Subject: Re: [PATCH] Suppress sign-conversion warning from FD_SET
- References: <20120525162702.053F819076C@elbrus2.mtv.corp.google.com><4FBFF85C.6050507@cs.ucla.edu> <CALoOobPKToFeUfs5v2V-fc1+AsqY+Tm1jUvw28o042Rsxr1xrg@mail.gmail.com><CALoOobM1b79j0ZhhiyLrpKWuDoCMTJEgfYrrzgtWQSjiys3vzw@mail.gmail.com><4FC117B4.7040503@cs.ucla.edu> <CALoOobO=6-L-KY-KvUqzpL2mRnzi0RdpbYDrieFzSpsaApNsuQ@mail.gmail.com><4FC49810.5090203@redhat.com> <CALoOobOMaSQNOHudNhMQxOu+6Wd3Tsw3Ye=Hs_R_-5Rx19tv_Q@mail.gmail.com>
On Tue, May 29, 2012 at 6:35 AM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Tue, May 29, 2012 at 2:34 AM, Pedro Alves <palves@redhat.com> wrote:
>
>>> + ? ? ?? (0 <= __d && __FD_SETSIZE < __d ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>>
>> looks like swapped by mistake.
>
> Ouch. Corrected.
>
> Thanks,
> --
> Paul Pluzhnikov
>
>
> 2012-05-29 ?Paul Pluzhnikov ?<ppluzhnikov@google.com>
>
> ? ? ?* debug/fdelt_chk.c (__fdelt_chk): Use signed long to avoid warning.
> ? ? ?* misc/bits/select2.h (__FD_ELT): Adjust for above.
No further comments. Deadline for 2.16 is today.
http://sourceware.org/ml/libc-alpha/2012-05/msg01879.html
Ok to commit?
Thanks,
--
Paul Pluzhnikov