This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use x86_64 bits/{io,perm}.h for i386 and x86_64
On Thu, 31 May 2012, Joseph S. Myers wrote:
> On Thu, 31 May 2012, H.J. Lu wrote:
>
> > Hi,
> >
> > This patch uses bits/{io,perm}.h for i386 and x86_64. OK to install?
>
> It's sys/, not bits/. The x86_64 version of sys/io.h seems to have a
> namespace problem that the i386 one doesn't (using "addr" instead of
> "__addr", "value" instead of "__value" as parameters) so I think you
> should actually be using the i386 version.
Correction:
x86_64 uses __value, i386 uses value. So in that case x86_64 is
preferred.
x86_64 uses addr, i386 uses __addr. So in that case i386 is preferred.
So you need to merge the two headers.
--
Joseph S. Myers
joseph@codesourcery.com