This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix sunrpc static library


On 05/21/2012 08:15 PM, Roland McGrath wrote:
Hmm.  Arguably this should be in shlib-compat.h instead, since
compat_symbol is only there.

I can move it, if you think this is better. strong_alias is defined in libc-symbols and that code has already some defines similar to this one. Do you prefer shlib-compat.h? I don't see a better place - unless we create a new include file just for this case which seems overkill to me,

I think shlib-compat.h is the better place, since code using this needs to include it and be using #if SHLIB_COMPAT (...) anyway.

Ok, I've committed this now with your suggested changes included.


thanks,
Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]