This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove sysdeps/powerpc/soft-fp


On Wed, May 16, 2012 at 5:44 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> As discussed in the thread starting at
> <http://sourceware.org/ml/libc-ports/2012-05/msg00099.html>,
> powerpc-nofpu glibc had some _q_* symbols accidentally added to
> version GLIBC_2.2 in glibc 2.4, but they have never been usefully
> usable at all and are intended for an ABI incompatible with that
> actually used. ÂI propose this patch to remove all these functions as
> discussed in that thread. Â(Despite only being used for a ports
> configuration, not for powerpc-fpu, this code is in libc. Âports has
> its own sysdeps/powerpc/soft-fp directory, containing sfp-machine.h
> which is all that's actually needed from such a directory for a
> powerpc-nofpu build.)
>
> Tested with a powerpc-nofpu build. ÂWith this change, the only
> remaining check-abi issues are those I listed for _mcount (a clear
> bug) and __fe_nomask_env (where I'd welcome further comment in that
> libc-ports thread - note that I don't see why __fe_mask_env or
> __fe_nomask_env are declared at all in the public
> sysdeps/powerpc/bits/fenv.h header, whatever we do about past ABI
> mistakes; the public interface is FE_MASK_ENV and FE_NOMASK_ENV and
> fesetenv, and the fpu version of fesetenv calls __fe_nomask_env and
> __fe_mask_env internally).
>
> 2012-05-16 ÂJoseph Myers Â<joseph@codesourcery.com>
>
> Â Â Â Â* sysdeps/powerpc/soft-fp/Makefile: Remove file.
> Â Â Â Â* sysdeps/powerpc/soft-fp/Subdirs: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/Versions: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_add.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_cmp.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_cmpe.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_div.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_dtoq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_feq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_fge.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_fgt.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_fle.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_flt.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_fne.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_itoq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_lltoq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_mul.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_neg.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_qtod.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_qtoi.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_qtoll.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_qtos.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_qtou.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_qtoull.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_sqrt.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_stoq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_sub.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_ulltoq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_util.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/q_utoq.c: Likewise.
> Â Â Â Â* sysdeps/powerpc/soft-fp/sfp-machine.h: Likewise.

I'm fine with this being removed but I'm curious as to how/why this
was every added in the first place.

I'm not sure what to do about the __fe_mask_env and __fe_nomask_env issue.

Ryan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]