This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Update sysdeps/x86_64/start.S for x32.


> -		0(%rsp)			argc
> -		8(%rsp)			argv[0]
> +		0(%rsp)				argc
> +		LP_SIZE(%rsp)			argv[0]
>  		...
> -		(8*argc)(%rsp)		NULL
> -		(8*(argc+1))(%rsp)	envp[0]
> +		(LP_SIZE*argc)(%rsp)		NULL
> +		(LP_SIZE*(argc+1))(%rsp)	envp[0]
>  		...
> -					NULL
> +						NULL

Fix the indentation (i.e. delete a tab) so the rhs lines up as before.

> +#ifdef __ILP32__
> +	mov (%rsp),%esi		/* Simulate popping 4byte argument count.  */
> +	addl $4,%esp
> +#else

Space after comma.  Why use "addl" when the trend is to drop the size
suffices everywhere they are superfluous?


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]