This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix missing vm86 symbol
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Fri, 04 May 2012 09:38:53 +0200
- Subject: Re: [PATCH v2] Fix missing vm86 symbol
- References: <4F91B682.4030306@suse.com> <Pine.LNX.4.64.1204291124080.1307@digraph.polyomino.org.uk> <m2y5peznc2.fsf_-_@igel.home> <m2lilcswbf.fsf_-_@igel.home> <20120501000456.A1D822C0AE@topped-with-meat.com>
On 05/01/2012 02:04 AM, Roland McGrath wrote:
Looks OK to me but certainly requires verified testing.
Thanks,
Roland
Just testing myself on i686 since I'd like to have the testsuite pass again:
The diff for sysd-syscalls is:
--- sysd-syscalls.old 2012-05-04 09:29:19.091100561 +0200
+++ sysd-syscalls 2012-05-04 09:29:25.821345128 +0200
@@ -76,8 +76,7 @@
echo '#define SYSCALL_NARGS 2'; \
echo '#define SYSCALL_SYMBOL __vm86'; \
echo '#include <syscall-template.S>'; \
- echo 'weak_alias (__vm86, vm86)'; \
- echo 'libc_hidden_weak (vm86)'; \
+ echo 'default_symbol_version(__vm86, vm86, GLIBC_2.3.4)'; \
) | $(compile-syscall) $(foreach p,$(patsubst
%vm86,%,$(basename $(@F))),$($(p)CPPFLAGS))
endif
ifeq (,$(filter vm86,$(bp-thunks)))
@@ -90,8 +89,6 @@
echo ' return (__vm86) (i1a, CHECK_1 (p2a)); \'; \
echo '} \'; \
echo 'libc_hidden_def (BP_SYM (__vm86)) \'; \
- echo 'weak_alias (BP_SYM (__vm86), BP_SYM (vm86)) \'; \
- echo 'libc_hidden_weak (BP_SYM (vm86)) \'; \
echo ''; \
echo '#include <bp-thunks.h>'; \
) | $(COMPILE.c) -x c -o $@ -
Tested on both Linux/x86-64 and Linux/x86.
And now make check-abi passes. Andreas, please commit,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126