This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove unused fork implementations
- From: David Miller <davem at davemloft dot net>
- To: joseph at codesourcery dot com
- Cc: libc-alpha at sourceware dot org, vapier at gentoo dot org
- Date: Tue, 24 Apr 2012 18:59:15 -0400 (EDT)
- Subject: Re: Remove unused fork implementations
- References: <Pine.LNX.4.64.1204242001460.31481@digraph.polyomino.org.uk>
From: "Joseph S. Myers" <joseph@codesourcery.com>
Date: Tue, 24 Apr 2012 20:04:07 +0000 (UTC)
> There are various implementations of fork under sysdeps/unix that are
> unused: Linux architectures all use versions under
> nptl/sysdeps/unix/sysv/linux and Hurd also has its own version.
>
> I propose this patch to remove the unused implementations. Tested
> x86_64. David, could you review the removal of the SPARC versions?
The sysdeps/unix/sparc/fork.S should not be used at all.
> (I'd also encourage looking at sysdeps/unix/sparc to see if anything
> else there is unused and should be removed.)
sysdeps/unix/sparc/sysdep.S is unused, overridden by:
sysdeps/unix/sysv/linux/sparc/sysdep.c
sysdeps/unix/sparc/brk.S is unused, overridden by:
sysdeps/unix/sysv/linux/sparc/sparc32/brk.c
sysdeps/unix/sysv/linux/sparc/sparc64/brk.S
sysdeps/unix/sparc/dl-brk.S is unused, overridden by:
sysdeps/unix/sysv/linux/sparc/sparc64/dl-brk.S
sysdeps/unix/sysv/linux/dl-brk.c
sysdeps/unix/sparc/pipe.S is unused, overridden by:
sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S
sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S
sysdeps/unix/sparc/vfork.S is unused, overridden by:
sysdeps/unix/sysv/linux/sparc/vfork.S
That leaves sysdeps/unix/sparc/sysdep.h which is used, by:
sysdeps/unix/sysv/linux/sparc/sparc32/sysdep.h
sysdeps/unix/sysv/linux/sparc/sparc64/sysdep.h
Should I move the contents of sysdeps/unix/sparc/sysdep.h into
sysdeps/sparc/sysdep.h?
The PIC bits are OS neutral, but the system call stuff is "UNIX"
specific.
So, maybe put the PIC bits into sysdeps/sparc/sysdep.h and put the
syscall stuff into sysdeps/unix/sysv/linux/sparc/sysdep.h?