This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap

From: Chung-Lin Tang <cltang at codesourcery dot com>
To: Andreas Jaeger <aj at suse dot com>
Cc: <libc-alpha at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, ThomasSchwinge <thomas_schwinge at mentor dot com>
Date: Tue, 24 Apr 2012 21:32:11 +0800
Subject: Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
References: <20120406194013.GA4689@intel.com> <4F96730D.3080505@codesourcery.com> <201204241319.56281.aj@suse.com>

On 2012/4/24 07:19 PM, Andreas Jaeger wrote:
> I suggest to solve this differently for sh.
> Currently you do:
> #if __BYTE_ORDER == __BIG_ENDIAN
> 
> Looking at sysdeps/sh/bits/endian.h, can't you use instead:
> #ifndef __LITTLE_ENDIAN__
> 
> Andreas

Agreed. Here's the corresponding fixes for SH, CCing Thomas.

Thanks,
Chung-Lin

2012-04-24  Chung-Lin Tang  <cltang@codesourcery.com>

	* sysdeps/sh/memcpy.S: Remove include of endian.h, change
	preprocessor endian tests to '#ifdef __BIG_ENDIAN__'.
	* sysdeps/sh/strlen.S: Likewise.

Attachment: sh-endian.diff
Description: Text document

Follow-Ups:
- Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
  - From: Thomas Schwinge

References:
- PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
  - From: H.J. Lu
- Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
  - From: Chung-Lin Tang
- Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
  - From: Andreas Jaeger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]