This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Clearify running testsuite as part of patch submission
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 17 Apr 2012 13:46:11 +0100
- Subject: Re: Clearify running testsuite as part of patch submission
- References: <201204171347.40012.aj@suse.com>
On 04/17/2012 12:47 PM, Andreas Jaeger wrote:
> Marek and myself just discussed about the testsuite on IRC and I've learned
> about the "xcheck" make target.
>
> I suggest that the "running the testsuite with a patch" gets clarified as:
> Run the whole testsuite with make "xcheck". Also, check-abi should be run
> in any case, thus you need to configure with --enable-check-abi.
>
> So, I suggest that we add to the wiki page
> http://sourceware.org/glibc/wiki/Contribution%20checklist in section
> "Testing" something like:
>
> Configure with --enable-check-abi and run the whole testsuite with "make
> xcheck".
If that's what everyone should be using, I'd suggest instead to
rename "make xcheck" -> "make check" (and perhaps keep the xcheck alias to
not break autotesters), and the current "make check" to something else. Would
that make sense? Admittedly, I've never ran the glibc testsuite myself,
but it'd be one thing less for newcomers to learn (such as myself).
"make check" is standard.
--
Pedro Alves