This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ld.so: Fix dlclose() removing required local scope elementsof NODELETE linkmaps
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Petr Baudis <pasky at ucw dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 13 Apr 2012 10:45:10 -0700 (PDT)
- Subject: Re: [PATCH] ld.so: Fix dlclose() removing required local scope elementsof NODELETE linkmaps
- References: <20120413164224.GF24309@machine.or.cz>
I don't know the details of this sufficiently well off hand to review the
logic of the change right now. So here's just some style points.
> +#define mark_used(dmap) \
We usually use inline functions (sometimes nested ones) rather than macros
when we can. This looks like a case where a nested inline would work fine.
> + mark_used(*lp);
Space before paren (other instances below).
Thanks,
Roland