This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use __builtin_bswap32/64 in __bswap_32/64 for GCC >= 4.2
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 6 Apr 2012 15:53:41 -0700 (PDT)
- Subject: Re: [PATCH] Use __builtin_bswap32/64 in __bswap_32/64 for GCC >= 4.2
- References: <20120406224349.GA8292@intel.com>
Please clean the file up to use __GNUC_PREREQ everywhere.
That's much easier to follow.
You're not just changing the behavior for GCC >= 4.2, which is what the log
entry says. You're also dropping the existing code for 2.0 <= GCC < 4.2.
That seems questionable. Please explain what effects this has on user code
compiled with e.g. GCC 4.1.
Thanks,
Roland