This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add --print-dirs option for ldconfig


> Add a -P|--print-dirs option to ldconfig for printing the linker
> search directories. 

Seems like a reasonable feature.  But call it --print-search-dirs,
consistent with the analogous gcc option.

> +2012-03-28  Dan Nicholson  <dbn.lists@gmail.com>
> +
> +	* elf/ldconfig.c: Add option to print linker path.

This log entry needs to be specific about the variables and functions
touched.

> +  if (opt_print_dirs)
> +    {
> +      struct dir_entry *entry;
> +
> +      for (entry = dir_entries; entry != NULL; entry = entry->next)

You can (and should) always use C99 syntax in glibc code.
So write:

    if (...)
      for (struct dir_entry *entry = dir_entries; entry != NULL; entry = entry->next)


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]