This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: iconvdata regression
On Sat, Mar 31, 2012 at 10:43 AM, Ryan S. Arnold <ryan.arnold@gmail.com> wrote:
> On Sat, Mar 31, 2012 at 4:34 AM, David Miller <davem@redhat.com> wrote:
>>
>> This commit:
>>
>> commit e64d2de526d8cfa2908e08892a534316a0bddf5f
>> Author: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>> Date: ? Fri Mar 30 10:43:43 2012 +0200
>>
>> ? ?Fix a bug when converting strings with 1 character using TCVN5712-1
>>
>> ? ?It isn't necessary to buffer the last character of strings. This can cause a
>> ? ?bug with strings that have 1 character between 0x0041 and 0x01b0.
>>
>> ? ? ? ?[BZ #13691]
>> ? ? ? ?* iconvdata/tcvn5712-1.c (FROM_LOOP): Fix a bug when converting strings
>> ? ? ? ?with only 1 character between 0x0041 and 0x01b0.
>> ? ? ? ?* wcsmbs/Makefile (tests): Add tst-mbsnrtowcs.
>> ? ? ? ?* wcsmbs/tst-mbsnrtowcs.c: New file.
>>
>> caused run-iconvtest.sh to start failing on Sparc, specifically:
>>
>> ? test data: TCVN-5712 -> UTF8 OK/FAILED
>>
>> Please fix this or revert your change, thanks.
>
> Tulio told me that he figured out what was happening and that
> (apologetically) he'll fix it on Monday. ?So we can either wait until
> then or one of us can revert it today (which is probably the better
> option).
What do other projects do in this case?
I'm all ears for suggestions here.
Automatic revert is an OK policy to suggest.
Dave, do you have an opinion here?
Cheers,
Carlos.