This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BZ#13691: Fix a bug when converting strings with 1 characterusing TCVN5712-1

On 03/30/2012 04:28 AM, Carlos O'Donell wrote: 
On Wed, Mar 28, 2012 at 2:41 PM, Tulio Magno Quites Machado Filho
<tuliom@linux.vnet.ibm.com>  wrote:

It isn't necessary to buffer the last character of strings. This can cause a
bug with strings that have 1 character between 0x0041 and 0x01b0.

2012-03-26 Tulio Magno Quites Machado Filho<tuliom@linux.vnet.ibm.com>

        [BZ #13691]
        * iconvdata/tcvn5712-1.c (FROM_LOOP): Fix a bug when converting strings
        with only 1 character between 0x0041 and 0x01b0.
        * wcsmbs/Makefile (tests): Add tst-mbsnrtowcs.
        * wcsmbs/tst-mbsnrtowcs.c: New file.

This looks good to me. Please check it in.

In the process of review I learned about UCS4, TCVN 5712-1 and a how
iconv/loop.c works :-)

I'm checking this in now on Tulio's behalf,

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]