This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unbound alloca in crypt routines

On Thu, Mar 29, 2012 at 1:55 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> > Not strictly necessary. ?However, I've found that keeping the if and else
>> > clauses at the same indention level makes the code easier to read. ?I'll
>> > defer to the maintainers on this.
>>
>> I agree. I prefer the braces.
>
> The existing style, and normal GNU style, has always been not to use
> superfluous braces. ?I see no reason to change that now.

Issues with the patch and project aside.

Would you agree or disagree that the normal GNU style of leaving out
braces makes code easier or harder to maintain in the long run, given
your experience?

Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]