This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unbound alloca in crypt routines

On 03/29/2012 11:26 AM, Carlos O'Donell wrote: 

The discussion of alloca is a separate conversation. If you want to
have that conversation we certainly can. Please start another thread
and we can take it from there.
Seems reasonable.

What kind of testing did you do here?
So far just verifying that with very long keys that we fall back to malloc rather than segfaulting. And that the we eventually returned from the crypt routine. It's quite painful simply due to the time it takes to run the test with very large keys.



Do you have a test case we could add to the testsuite that exercises
the new malloc case?
I just cobbled the attached code based on the python test I was provided. Nothing terribly special, just create a big key, ensure it's misaligned and send it to the various crypt routines.

Jeff

Attachment: crypt.c
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]