This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RESEND-2][PATCH][BZ #13760] Fix dns lookup for AF_UNSPEC whenresponse for T_A exceeds buffer size
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 28 Mar 2012 11:51:58 +0200
- Subject: Re: [RESEND-2][PATCH][BZ #13760] Fix dns lookup for AF_UNSPEC whenresponse for T_A exceeds buffer size
- References: <20120326115650.325c410a@spoyarek>
On 03/26/2012 08:26 AM, Siddhesh Poyarekar wrote:
Hi,
Resending once again.
Regards,
Siddhesh
Begin forwarded message:
Date: Wed, 14 Mar 2012 18:33:34 +0530
From: Siddhesh Poyarekar<siddhesh@redhat.com>
To: libc-alpha@sourceware.org
Cc: Carlos O'Donell<carlos@systemhalted.org>, Jeff Law<law@redhat.com>
Subject: [RESEND][PATCH][BZ #13760] Fix dns lookup for AF_UNSPEC when
response for T_A exceeds buffer size
ping.
--
Siddhesh
> [...]
The current check looks for the ERANGE error in 'errno' when it should
be looking for it in *errnop (where gaih_getanswer_slice sets
The single change for *errnop is ok.
it). Also, we should discard the second response and retry the query
in case of NSS_STATUS_TRYAGAIN and ERANGE (buffer too small) only when
the response error is recoverable. The only condition in which this
currently occurs (buffer too small and h_errno is NO_RECOVERY) is when
the hostname returned by the query is longer than MAXHOSTNAMELEN.
I don't see how this is addressed with your change. Is the patch
incomplete - or what do I miss?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126