This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x32 support to sysdeps/x86_64/dl-tlsdesc.h

I think the bit using the union warrants a comment explaining why it's there.

> 	* sysdeps/x86_64/dl-tlsdesc.h (tlsdesc): Use anonymouse union

typo: s/anonymouse/anonymous/

> +      ptrdiff_t (*entry)(struct tlsdesc *on_rax);

Missing space before paren.

With those nits fixed, I'm happy with the change.
But I'd be happier yet if other people gave opinions
about the union trick vs explicit #ifdef's padding fields.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]