This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Configure x86_64 in sysdeps/x86_64/preconfigure

> 2012-03-21  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* sysdeps/x86_64/preconfigure: New file.

Should be:

	* sysdeps/x86_64/preconfigure.in: New file.
	* sysdeps/x86_64/preconfigure: New generated file.

> diff --git a/sysdeps/x86_64/preconfigure b/sysdeps/x86_64/preconfigure

It's normal to omit the generated files when posting a patch.

> +  AC_CACHE_CHECK(if we are building for x32, libc_cv_x32, [dnl

The usual convention is something like:

AC_CACHE_CHECK([whether $CC compiles in -mx32 mode by default], ...

> +cat > conftest.c <<\EOF
> +#ifdef __LP64__
> +# error not x32
> +#endif
> +EOF
> +  dnl
> +  if AC_TRY_COMMAND(${CC-cc} -c $CFLAGS $CPPFLAGS conftest.c 1>&AS_MESSAGE_LOG_FD); then

Why not use AC_TRY_COMPILE?


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]