This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/4] s390: Add <bits/hwcap.h>.

From: Roland McGrath <roland at hack dot frob dot com>
To: Richard Henderson <rth at twiddle dot net>
Cc: libc-alpha at sourceware dot org, Martin Schwidefsky <schwidefsky at de dot ibm dot com>, Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
Date: Fri, 16 Mar 2012 16:40:49 -0700 (PDT)
Subject: Re: [PATCH 2/4] s390: Add <bits/hwcap.h>.
References: <1331940632-7136-1-git-send-email-rth@twiddle.net><1331940632-7136-3-git-send-email-rth@twiddle.net><20120316233727.874A72C0D1@topped-with-meat.com><4F63CF23.3010709@twiddle.net>

> On 03/16/12 16:37, Roland McGrath wrote:
> >> +#define HWCAP_S390_ESAN3        1
> >> +#define HWCAP_S390_ZARCH        2
> >> +#define HWCAP_S390_STFLE        4
> >> +#define HWCAP_S390_MSA          8
> >> +#define HWCAP_S390_LDISP        16
> >> +#define HWCAP_S390_EIMM         32
> >> +#define HWCAP_S390_DFP          64
> >> +#define HWCAP_S390_HPAGE        128
> >> +#define HWCAP_S390_ETF3EH       256
> >> +#define HWCAP_S390_HIGH_GPRS    512
> > 
> > Hex or (1 << n) is nicer.
> 
> This is literally cut and paste from linux/**/asm/elf.h.
> I could obviously diverge from the kernel if required ...

Then I guess it's better to keep it verbatim so eyeball sync is easier in
the future.

References:
- [PATCH 0/4] Export AT_HWCAP from libc.
  - From: Richard Henderson
- [PATCH 2/4] s390: Add <bits/hwcap.h>.
  - From: Richard Henderson
- Re: [PATCH 2/4] s390: Add <bits/hwcap.h>.
  - From: Roland McGrath
- Re: [PATCH 2/4] s390: Add <bits/hwcap.h>.
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]