This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH 15/17] mktime: merge comment-quoting-style change from gnulib
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 16 Mar 2012 03:40:40 -0700
- Subject: [PATCH 15/17] mktime: merge comment-quoting-style change from gnulib
* time/mktime.c: Quote 'like this' in comments.
The GNU coding standards suggest that we no longer quote `like this',
as "`" and "'" are typically rendered asymmetrically nowadays.
The typical gnulib style is to quote 'like this' when quoting
code, and "like this" when quoting English.
---
ChangeLog | 7 +++++++
time/mktime.c | 6 +++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0d38f4e..83bd0f2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2012-03-16 Paul Eggert <eggert@cs.ucla.edu>
+ mktime: merge comment-quoting-style change from gnulib
+ * time/mktime.c: Quote 'like this' in comments.
+ The GNU coding standards suggest that we no longer quote `like this',
+ as "`" and "'" are typically rendered asymmetrically nowadays.
+ The typical gnulib style is to quote 'like this' when quoting
+ code, and "like this" when quoting English.
+
* time/mktime.c (compile-command): Add "-I.".
mktime: avoid signed integer overflow
diff --git a/time/mktime.c b/time/mktime.c
index 7e8c9df..3728cbb 100644
--- a/time/mktime.c
+++ b/time/mktime.c
@@ -1,4 +1,4 @@
-/* Convert a `struct tm' to a time_t value.
+/* Convert a 'struct tm' to a time_t value.
Copyright (C) 1993-1999, 2002-2007, 2008 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Paul Eggert <eggert@twinsun.com>.
@@ -26,7 +26,7 @@
#endif
/* Assume that leap seconds are possible, unless told otherwise.
- If the host has a `zic' command with a `-L leapsecondfilename' option,
+ If the host has a 'zic' command with a '-L leapsecondfilename' option,
then it supports leap seconds; otherwise it probably doesn't. */
#ifndef LEAP_SECONDS_POSSIBLE
# define LEAP_SECONDS_POSSIBLE 1
@@ -583,7 +583,7 @@ mktime (struct tm *tp)
{
#ifdef _LIBC
/* POSIX.1 8.1.1 requires that whenever mktime() is called, the
- time zone names contained in the external variable `tzname' shall
+ time zone names contained in the external variable 'tzname' shall
be set as if the tzset() function had been called. */
__tzset ();
#endif
--
1.7.6.5