This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH [1/n]: Initial x32 support


On Thu, 15 Mar 2012, Roland McGrath wrote:

> > > 	* configure.in: Add sysdeps preconfigure fragment support.
> > 
> > The principle of having such a fragment is good, but I think you're 
> > running them too late.  I think you should run sysdeps preconfigure 
> > fragments (all of them) from libc at around the same time they are run for 
> > add-ons.  This allows libc targets to look more like ports ones in that 
> > the code
> 
> I'm not sure I follow this notion at all.  The reason I added preconfigure
> was for things that need to influence the sysdirs list algorithm, like
> setting base_machine and so forth.  Once the sysdirs list has been chosen,
> we have sysdeps configure fragments.  So what's a sysdeps preconfigure for?

The idea is that all of them would be run (whatever directory they are 
in), just as they are in add-ons (with the same convention that it's a bug 
for such a fragment to do anything for an unrelated target), but logically 
sysdeps directories seem a better place for architecture-specific logic 
that sets base_machine than toplevel configure.in does.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]