Re: Fix for bz#13658 - using fsincos on x86-64

[Andreas Jaeger <aj at suse dot com>]

On Wednesday, March 14, 2012 16:35:52 Joseph S. Myers wrote:
> On Wed, 14 Mar 2012, Andreas Jaeger wrote:
> > I hope so as well. Will you continue this or shall I make a combined
> > patch tomorrow?
> 
> I suggest you make the combined patch tomorrow.

Will do my best.
 
> > > +
> > > +#ifdef NEED_53BIT_PRECISION
> > 
> > Where do you define NEED_53BIT_PRECISION ?
> 
> It looks like I pruned the patch too heavily when cutting out the
> removed files; there should be:

;)
 
No problem.

> diff --git a/sysdeps/i386/fpu/s_sin.c b/sysdeps/i386/fpu/s_sin.c
> new file mode 100644
> index 0000000..dccff13
> --- /dev/null
> +++ b/sysdeps/i386/fpu/s_sin.c
> @@ -0,0 +1,2 @@
> +#define NEED_53BIT_PRECISION
> +#include <sysdeps/ieee754/dbl-64/s_sin.c>
> 
> But actually that's redundant; the conditions and #define are relics of
> my older idea of redefining existing macros only in certain files,
> rather than having new macros making it explicit for the affected
> functions that they need 53-bit precision rather than hiding it
> elsewhere.  So you can remove the #ifdef NEED_53BIT_PRECISION, and then
> don't need the x86 version of s_sin.c.

That's what I expected, ok will do,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126