Re: [patch] Eliminate generated source dependency on internals ofAWK used

[Andreas Jaeger <aj at suse dot com>]

On 03/02/2012 02:07 AM, Paul Pluzhnikov wrote:
> Greetings,
>
> Here at Google we like to be able to build bit-identical binaries given
> the same sources.

So, you're removing the date command from csu/Makefile as well?

> It turns out that the errlist script output depends on internals of AWK
> (order of elements in associative array).
>
> Attached patch fixes that.

This is ok,

thanks,
Andreas

> Thanks,
> --
> Paul Pluzhnikov
>
>
> 2012-03-01  Chris Demetriou<cgd@google.com>
>
> 	* sysdeps/gnu/errlist-compat.awk: Don't depend on AWK internals.
>
>
> diff --git a/sysdeps/gnu/errlist-compat.awk b/sysdeps/gnu/errlist-compat.awk
> index 0e97d05..4f70e92 100644
> --- a/sysdeps/gnu/errlist-compat.awk
> +++ b/sysdeps/gnu/errlist-compat.awk
> @@ -84,7 +84,10 @@ END {
>       printf "#define ERR_MAX %d\n\n", highest;
>     }
>
> -  for (old in compat) {
> +  # same regardless of awk's ordering of the associative array.
> +  num_compat_elems = asorti(compat, compat_indices)
> +  for (i = 1; i<= num_compat_elems; i++) {
> +    old = compat_indices[i]
>       new = compat[old];
>       n = vcount[old];
>       printf "#if SHLIB_COMPAT (libc, %s, %s)\n", old, new;


--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126