Re: [PATCH][TRY5][BZ #13637] fix false multi-byte matches in some regular expressions + testcase

[Andreas Jaeger <aj at suse dot com>]

On Monday, February 27, 2012 16:32:37 Carlos O'Donell wrote:
> On Mon, Feb 27, 2012 at 10:15 AM, Stanislav Brabec <sbrabec@suse.cz> 
wrote:
> > [This patch contains Japanese UTF-8 characters in C code comments.
> > Please use http://sourceware.org/bugzilla/show_bug.cgi?id=13637#c4 in
> > case of problems.]
> > 
> > Changes since TRY4:
> > - Testcase uses test-skeleton.c.
> > - Uses SBC_MAX and includes "regex_internal.h".
> > - Setup fastmap before call to re_compile_pattern.
> > - bug-regex33.6 comment updated: There is one true and one false
> > match.
> > 
> > From 34d1941f1c33fe3210239e95773e5ae53089cf52 Mon Sep 17 00:00:00 2001
> > From: Stanislav Brabec <sbrabec@suse.cz>
> > Date: Mon, 27 Feb 2012 15:22:22 +0100
> > Subject: * posix/regex_internal.c (re_string_skip_chars): Fix
> > miscomputation of remain_len that may cause incomplete multi-byte
> > character and false match. * posix/bug-regex33.c: New file.
> >  * posix/Makefile (tests): Add bug-regex33.
> 
> This looks great. Thanks!
> 
> If the testsuite shows no regression please check this in to trunk

I just committed this on behalf of Stanislav, there were no regressions on 
my machine.

Thanks Stanislav!

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126