Re: Avoid local PLT for dirfd

[Andreas Jaeger <aj at suse dot com>]

On Tuesday, February 28, 2012 13:55:22 Jakub Jelinek wrote:
> On Tue, Feb 28, 2012 at 01:19:16PM +0100, Andreas Jaeger wrote:
> > Running make check I noticed a local PLT failure:
> > 
> > cat elf/check-localplt.out
> > --- ../scripts/data/localplt-generic.data       2009-06-03
> > 09:17:46.000000000 +0200 +++ -   2012-02-28 12:16:38.670783466 +0100
> > @@ -1,4 +1,5 @@
> > 
> >  libc.so: calloc
> > 
> > +libc.so: dirfd
> > 
> >  libc.so: free
> >  libc.so: malloc
> >  libc.so: memalign
> > 
> > I'm appending a patch to fix this. Tested on Linux/x86-64.
> 
> I'd say you should not introduce __dirfd, but instead just
> add libc_hidden_proto (dirfd) (in include/dirent.h) and
> libc_hidden_def (dirfd) (in the dirfd.c).
> Then you don't need to adjust any users of that function.

Thanks, will change the patch,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126