This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Make fmtmsg() function to multithread-safe
- From: Ulrich Drepper <drepper at gmail dot com>
- To: Peng Haitao <penght at cn dot fujitsu dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 24 Feb 2012 21:20:12 -0500
- Subject: Re: [PATCH v2] Make fmtmsg() function to multithread-safe
- Authentication-results: mr.google.com; spf=pass (google.com: domain of drepper@gmail.com designates 10.60.14.34 as permitted sender) smtp.mail=drepper@gmail.com; dkim=pass header.i=drepper@gmail.com
- References: <4F44532B.4030001@cn.fujitsu.com>
That patch is wrong. If addseverity is used to remove or change an
entry (the only possible reason to add this lock) then the string can
be removed as well. In this case it's not sufficient to just lock
around the search. I checked in a patch fixing that problem.