This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Always set l_used for vDSO (BZ #13706)
"Carlos O'Donell" <carlos@systemhalted.org> writes:
> On Fri, Feb 24, 2012 at 1:02 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Marek Polacek <polacek@redhat.com> writes:
>>
>>> +$(objpfx)tst-unused-dep.out: $(objpfx)testobj1.so
>>> + Â Â LD_TRACE_LOADED_OBJECTS=1 \
>>> + Â Â LD_DEBUG=unused \
>>> + Â Â $(elf-objpfx)${rtld-installed-name} \
>>> + Â Â Â --library-path $(rpath-link)$(patsubst %,:%,$(sysdep-library-path)) \
>>> + Â Â Â $< | grep -E "linux-(gate|vdso)(32|64)?.so.1" > $@ || :
>>
>> IMHO any output should be considered a failure. ÂYou don't know how
>> future VDSOs will be named.
>
> ... and it fails, and we notice, and fix it.
You won't notice.
> Test don't need to be future proof they just need to fail safe.
This test is not fail safe.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."