This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Clean up glibc version numbers in manual


> +libc-texi-generated = chapters.texi top-menu.texi dir-add.texi \
> +	libm-err.texi version.texi

Usual convention is to indent to after "= ".

> +# Generate a file with the version number.
> +version.texi: $(common-objpfx)config.make
> +	echo "@set VERSION $(version)" > version-tmp
> +	$(move-if-change) version-tmp version.texi
> +	touch $@

It seems odd to both use move-if-change and always touch the file.
If you always touch it, just do "> $@T" and "mv -f $@T $@" as usual.
If we care to avoid gratuitous regeneration of the formatted manuals,
then this rule and the dependencies need to use a stamp file.

> @@ -176,7 +184,7 @@ realclean: distclean
>  	-rm -f texis summary.texi stamp-summary *.c.texi dir-add.texi
>  	-rm -f $(foreach index,$(indices),libc.$(index) libc.$(index)s)
>  	-rm -f libc.log libc.aux libc.toc dir-add.texinfo
> -	-rm -f top-menu.texi chapters.texi
> +	-rm -f top-menu.texi chapters.texi version.texi

Why not just use libc-texi-generated here too?

> +@c @set EDITION 0.13
> +@c @set ISBN 1-882114-55-8

I think it merits having a comment explaining that we're diking out all the
text associated with printed editions, pending resolving how those will be
handled.  For each of the other blocks below, a short comment referring to
the explanation above.  That makes it easier to be sure we clean up all the
old cruft when we figure out the new plan.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]