This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Always set l_used for vDSO (BZ #13706)

On Fri, Feb 24, 2012 at 7:38 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Fri, Feb 24, 2012 at 01:23:27PM +0100, Andreas Schwab wrote:
>> That doesn't match linux-vdso32.so.1 and linux-vdso64.so.1.
>
> Thanks, fixed. ?Now it matches even linux-gate(32|64).so.1, but that shouldn't
> be a problem. ?Ok now?
>
> 2012-02-24 ?Marek Polacek ?<polacek@redhat.com>
>
> ? ? ? ?[BZ #13706]
> ? ? ? ?* elf/rtld.c (dl_main): Always set l_used to 1 for vDSO.
> ? ? ? ?* elf/Makefile: Add rules to run tst-unused-dep.out.

Excellent! Thank you for creating a regression test.

The rule looks good to me, makes sense, and is easy to maintain.

Please check this in tomorrow if nobody objects today.

Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]