Re: [PATCH] Fix compilation of regex.c on Hurd

[Thomas Schwinge <thomas at schwinge dot name>]

Hi!

On Thu, 16 Feb 2012 11:15:01 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote:
> Since commit 54dd0ab31fe2b2168ba1a6180a0c05941fb54b3c, the MAX macro is
> used in regex_internal.c which is included by regex.c, while it is not 
> defined on the include on Hurd.
> 
> On other architectures it is defined in <sys/param.h> which is included 
> in a weird way:
> 
> from ../sysdeps/i386/i686/hp-timing.h:25,
> from ../sysdeps/x86_64/hp-timing.h:23,
> from ../nptl/descr.h:28,
> from ../nptl/sysdeps/x86_64/tls.h:98,
> from ../include/tls.h:6,
> from ../bits/libc-tsd.h:45,
> from ../locale/localeinfo.h:210,
> from regex.c:54
> 
> 
> 2012-02-16  Aurelien Jarno  <aurelien@aurel32.net>
> 
> 	[BZ #11638]
> 	* posix/regex_internal.h: include <sys/param.h> to get MAX
> 	definition.

Generally ACK (but not in the sense of commit approval); though I would
(and have, in our trees) put the #include <sys/param.h> nearer to where
it is used, that is into regex_internal.c instead of regex_internal.h.


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature