This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix math functions triggering invalid exceptions
On Wed, Feb 15, 2012 at 3:29 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Wed, Feb 15, 2012 at 08:55:52PM +0000, Joseph S. Myers wrote:
...
>> So I think you should repost with those fixes, and then commit if noone
>> else spots any problems and if it's been tested on both an affected
>> platform and one that didn't previously have the issue you report.
>>
>
> Thanks for the review. Here is the new patch.
>
>
> 2012-02-15 ÂAurelien Jarno Â<aurelien@aurel32.net>
>
> Â Â Â Â* math/w_acos.c: Use non-signaling floating-point comparisons.
> Â Â Â Â* math/w_acosf.c: Likewise.
> Â Â Â Â* math/w_acosh.c: Likewise.
> Â Â Â Â* math/w_acoshf.c: Likewise.
> Â Â Â Â* math/w_acoshl.c: Likewise.
> Â Â Â Â* math/w_acosl.c: Likewise.
> Â Â Â Â* math/w_asin.c: Likewise.
> Â Â Â Â* math/w_asinf.c: Likewise.
> Â Â Â Â* math/w_asinl.c: Likewise.
> Â Â Â Â* math/w_atanh.c: Likewise.
> Â Â Â Â* math/w_atanhf.c: Likewise.
> Â Â Â Â* math/w_atanhl.c: Likewise.
> Â Â Â Â* math/w_exp2.c: Likewise.
> Â Â Â Â* math/w_exp2f.c: Likewise.
> Â Â Â Â* math/w_exp2l.c: Likewise.
> Â Â Â Â* math/w_j0.c: Likewise.
> Â Â Â Â* math/w_j0f.c: Likewise.
> Â Â Â Â* math/w_j0l.c: Likewise.
> Â Â Â Â* math/w_j1.c: Likewise.
> Â Â Â Â* math/w_j1f.c: Likewise.
> Â Â Â Â* math/w_j1l.c: Likewise.
> Â Â Â Â* math/w_jn.c: Likewise.
> Â Â Â Â* math/w_jnf.c: Likewise.
> Â Â Â Â* math/w_log.c: Likewise.
> Â Â Â Â* math/w_log10.c: Likewise.
> Â Â Â Â* math/w_log10f.c: Likewise.
> Â Â Â Â* math/w_log10l.c: Likewise.
> Â Â Â Â* math/w_log2.c: Likewise.
> Â Â Â Â* math/w_log2f.c: Likewise.
> Â Â Â Â* math/w_log2l.c: Likewise.
> Â Â Â Â* math/w_logf.c: Likewise.
> Â Â Â Â* math/w_logl.c: Likewise.
> Â Â Â Â* math/w_sqrt.c: Likewise.
> Â Â Â Â* math/w_sqrtf.c: Likewise.
> Â Â Â Â* math/w_sqrtl.c: Likewise.
> Â Â Â Â* sysdeps/ieee754/dbl-64/e_atanh.c: Likewise.
> Â Â Â Â* sysdeps/ieee754/dbl-64/w_exp.c: Likewise.
> Â Â Â Â* sysdeps/ieee754/flt-32/e_atanhf.c: Likewise.
> Â Â Â Â* sysdeps/ieee754/flt-32/w_expf.c: Likewise.
> Â Â Â Â* sysdeps/ieee754/ldbl-96/w_expl.c: Likewise.
Please hold up on checking this in. We'd like some time to
investigate the performance implications of these additional
comparisons which very well may be unnecessary on Power.
Ryan S. Arnold