This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add --disable-timezone configure option
On Wed, 15 Feb 2012, Carlos O'Donell wrote:
> On Tue, Feb 14, 2012 at 10:15 PM, Roland McGrath <roland@hack.frob.com> wrote:
> >> I'm not sure there's much benefit to actually having a package include
> >> copies of the data rather than having a --with- argument pointing to where
> >> the data files may be found. ?By using --with, the package would only need
> >> updating pretty infrequently (and people generally want minimal latency
> >> when getting tzdata updates).
> >
> > I hadn't thought of that. ?It sounds fine too.
>
> I also like the idea of a --with- argument because it helps us run the
> tests against the tzdata provided by the distro.
>
> We should *also* IMO include legacy tzdata binaries in glibc to test
> compatibility with old formats, I am 100% for including old binary
> data (not in the source, but in a seperate checkout to avoid the pain
> of grep'ing through binary data e.g. --with-glibc-data).
I think separating out testcases to another directory is undue complexity
for something testing functionality within the core libc (except for any
unusual cases where e.g. tests are extremely large but it's still useful
to run them occasionally). Concern about checking in binary files could
be addressed by checking in a version encoded to text in some way and
decoding when the testsuite is run.
--
Joseph S. Myers
joseph@codesourcery.com