Re: [RFC] Provide crt[in].S for x86-64

[Andreas Jaeger <aj at suse dot com>]

On 02/09/2012 04:59 PM, Marek Polacek wrote:
> On 02/08/2012 04:45 PM, Joseph S. Myers wrote:
> > That #else case looks wrong, you still need to call the function
> > (directly) in the non-weak case, and the final addq and ret should only be
> > in the epilogue in crtn.S, not in crti.S, so that all the other functions
> > other objects contribute to the .init section are called.
>
> Fixed.  Slightly tested on x86_64-redhat-linux.  Ok?
>
> 2012-02-09  Marek Polacek<polacek@redhat.com>
>
> 	* sysdeps/x86_64/crti.S: New file.
> 	* sysdeps/x86_64/crtn.S: New file.
> 	* sysdeps/x86_64/elf/initfini.c: Remove file.
>
> --- libc/sysdeps/x86_64/crtn.S.mp	2012-02-08 15:33:53.221898023 +0100
> +++ libc/sysdeps/x86_64/crtn.S	2012-02-09 16:05:17.704562797 +0100
> @@ -0,0 +1,47 @@
> +/* Special .init and .fini section support for x86-64.
> +   Copyright (C) 2012 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +   Contributed by Marek Polacek<polacek@redhat.com>, 2012.

Just a matter of style: I wonder about just one thing - is the 
contributed line really fair here? It's the same code as in initfini.c 
that is presenter in a nicer way.

Thanks Marek for doing this - the conversation looks fine to me now,
Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126