This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: initfini.c -> crt[in].S


On Tue, 7 Feb 2012, Roland McGrath wrote:

> > > It's fine to use an abstract description like yours when the condition
> > > has hairy syntax like this one does.  But the [] convention makes it
> > 
> > Indeeed, I tried the [] syntax, but with [ifneq (,$(wildcard 
> > $(sysdirs:%=%/crti.S)))] the logs are even less readable.
> 
> I meant, it's fine to use an abstract description inside [].
> Your wording without [] makes it not at all clear it's referring
> to conditionalized code.  Please fix that.

This is the log version I'll commit once testsuite runs for the latest 
patch have completed both on x86 and another architecture (to verify that 
the legacy case is still working in the latest version).  I'll also close 
bug 411 as fixed and update NEWS to reflect that it is fixed since this 
patch resolves the last case of that bug (by making these files use 
sysdep.h), and send a separate message about the change to libc-alpha and 
libc-ports (and in due course update the ports I maintain in the ports 
repository).

2012-02-08  Joseph Myers  <joseph@codesourcery.com>

	Support crti.S and crtn.S provided directly by architectures.
	* csu/Makefile [crti.S in sysdirs] (generated): Do not append.
	[crti.S in sysdirs] (omit-deps): Likewise.
	[crti.S in sysdirs] (CFLAGS-initfini.s): Do not define variable.
	[crti.S in sysdirs] ($(crtstuff:%=$(objpfx)%.o)): Disable rule.
	[crti.S in sysdirs] ($(objpfx)initfini.s): Likewise.
	[crti.S in sysdirs] ($(objpfx)crti.S): Likewise.
	[crti.S in sysdirs] ($(objpfx)crtn.S): Likewise.
	[crti.S in sysdirs] ($(patsubst %,$(objpfx)crt%.o,i n)): Likewise.
	[crti.S in sysdirs] ($(objpfx)defs.h): Likewise.
	[crti.S in sysdirs] (initfini.c): Remove vpath directive.
	* sysdeps/i386/crti.S, sysdeps/i386/crtn.S: New files, based on
	compiler output for sysdeps/generic/initfini.c.
	* sysdeps/i386/elf/Makefile: Remove file.
	* sysdeps/i386/Makefile (CFLAGS-initfini.s): Remove variable.

nptl:
2012-02-08  Joseph Myers  <joseph@codesourcery.com>

	Support crti.S and crtn.S provided directly by architectures.
	* Makefile [crti.S in sysdirs] (omit-deps): Do not append.
	[crti.S in sysdirs] (CFLAGS-pt-initfini.s): Do not define variable.
	[crti.S in sysdirs] ($(objpfx)pt-initfini.s): Disable rule.
	[crti.S in sysdirs] ($(objpfx)crti.S): Likewise.
	[crti.S in sysdirs] ($(objpfx)crtn.S): Likewise.
	[crti.S in sysdirs] ($(objpfx)defs.h): Likewise.
	[crti.S in sysdirs] ($(objpfx)crti.o): Likewise.
	[crti.S in sysdirs] ($(objpfx)crtn.o): Likewise.
	[crti.S in sysdirs] (pt-initfini.c): Remove vpath directive.
	[crti.S in sysdirs] ($(objpfx)crti.o): New rule.
	* pt-crti.S: New file.
	* sysdeps/unix/sysv/linux/i386/Makefile: Remove file.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]