This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use __unused0 instead of __unused for user visiblestruct members
- From: Guillem Jover <guillem at hadrons dot org>
- To: Ulrich Drepper <drepper at gmail dot com>
- Cc: Carlos O'Donell <carlos at systemhalted dot org>, libc-alpha at sourceware dot org
- Date: Tue, 7 Feb 2012 23:27:00 +0100
- Subject: Re: [PATCH] Use __unused0 instead of __unused for user visiblestruct members
- References: <20120102030627.GA10869@gaara.hadrons.org><CAOPLpQf_kr1EOguKau_co9Q96tgRNBDwfO6CBNF7jnnSrzEPvA@mail.gmail.com><CADZpyixstsdjeQaJ6WAU4rnY8dGMUi_wgzYCuPxU0uRXxCcSVA@mail.gmail.com><CAOPLpQdnHQ5ezbohKQgRAnofSureJQtcjKiEsNBWVsA5nr9zsA@mail.gmail.com><CADZpyiw7q1bTKb6wNNDbZhbwFKg36oE8+m8M+VtevGzt3JtRfA@mail.gmail.com><CAOPLpQeYL6LAqUu3GQzzK7fcVc7gApKJB6Y5AmKK=mu3m4nbFQ@mail.gmail.com>
Hi!
This is probably my last mail on this issue, as it does not seem to be
going anywhere. Thanks Carlos for your perseverance, though!
On Mon, 2012-01-09 at 17:01:48 -0500, Ulrich Drepper wrote:
> These are no save names to use. Only the fact that for decades the _
> name space is reserved helps. If BSD think they can do what they want
> just don't use their code.
FreeBSD introduced this more than 15 years ago:
<http://svnweb.freebsd.org/base/head/sys/sys/cdefs.h?r1=15243&r2=17648>
NetBSD synced it from FreeBSD more recently, 5 years ago in rev 1.62:
<http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/cdefs.h?only_with_tag=MAIN>
> Have them fix their code and not introduce into general namespaces.
As mentioned before I disagree this is broken on BSDs, it's part of
their system implementation. So this is not going to change on their
side, more so with 15 years of code being able to rely on those
symbols, so trying to talk BSD people into changing those symbols
seems pointless, more so when the counterpart change on glibc does
not affect any public interface.
Given the current maintainer stance, and the other available
(suboptimal) options, I'll probably be adding #include_next wrapper
headers into a private hierarchy provided by libbsd, for any of those
using __unused struct members, to be able to redefine them to
something else.
thanks,
guillem