This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap


One more thing.  Aren't there similar integer or stack overflow problems
in other parts of the vfprintf.c code?  E.g.:

              string = (CHAR_T *) alloca (len * sizeof (wchar_t));            \

            specs = extend_alloca (specs, nspecs_size, 2 * nspecs_size);

              args_value[cnt].pa_user = alloca (args_size[cnt]);

(This is not an exhaustive list.)  I'm not asking you to fix all
of them right now, just for whether you think these other things
need fixing too.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]