Re: [PATCH] vfprint: validate nargs and argument-based offsets

[Roland McGrath <roland at hack dot frob dot com>]

> I believe that you should add a GLIBC copyright header, including
> copyright year and a "Contributed by " statement but perhaps someone
> else with an opinion can comment.

Certainly it should have a standard copyright comment.
Please make the first line a file-describing comment rather
than just the copyright line.

Adding "Contributed by" or "Written by" is entirely up to the author.
Some people like to be credited explicitly in more places, while for
others the ChangeLog and source control history are more than enough.
I don't add them, since it's just another way for randoms to find your
name and email address on some code and ask you truly bizarre and
unrelated questions a decade later (trust me, you have no idea).
(This isn't really relevant for a simple test case that won't change
much, but in the general case such lines can be awkward because nobody
wants to slight the original author by removing them, but over time
the file is likely to be added to or rewritten substantially by
someone else, making the credit imprecise at best.)


Thanks,
Roland