This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix nits in comments
- From: Marek Polacek <polacek at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Fri, 23 Dec 2011 11:14:52 +0100
- Subject: Re: [PATCH] Fix nits in comments
- References: <4E736D78.7020809@redhat.com>
Ping.
On 09/16/2011 05:38 PM, Marek Polacek wrote:
> Found these while reading dl-machine.h. Intentionally, I do not attach the
> CL entry.
>
> --- libc/sysdeps/x86_64/dl-machine.h.mp 2011-09-16 15:18:19.983668201 +0200
> +++ libc/sysdeps/x86_64/dl-machine.h 2011-09-16 15:24:12.590545039 +0200
> @@ -98,7 +98,7 @@ elf_machine_runtime_setup (struct link_m
> /* The GOT entries for functions in the PLT have not yet been filled
> in. Their initial contents will arrange when called to push an
> offset into the .rel.plt section, push _GLOBAL_OFFSET_TABLE_[1],
> - and then jump to _GLOBAL_OFFSET_TABLE[2]. */
> + and then jump to _GLOBAL_OFFSET_TABLE_[2]. */
> got = (Elf64_Addr *) D_PTR (l, l_info[DT_PLTGOT]);
> /* If a library is prelinked but we have to relocate anyway,
> we have to be able to undo the prelinking of .got.plt.
> @@ -210,7 +210,7 @@ _dl_start_user:\n\
> /* The x86-64 never uses Elf64_Rel relocations. */
> #define ELF_MACHINE_NO_REL 1
>
> -/* We define an initialization functions. This is called very early in
> +/* We define an initialization function. This is called very early in
> _dl_sysdep_start. */
> #define DL_PLATFORM_INIT dl_platform_init ()
>
> @@ -230,8 +230,8 @@ elf_machine_fixup_plt (struct link_map *
> return *reloc_addr = value;
> }
>
> -/* Return the final value of a plt relocation. On x86-64 the
> - JUMP_SLOT relocation ignores the addend. */
> +/* Return the final value of a PLT relocation. On x86-64 the
> + JUMP_SLOT relocation ignores the addend. */
> static inline Elf64_Addr
> elf_machine_plt_value (struct link_map *map, const Elf64_Rela *reloc,
> Elf64_Addr value)