Re: [PATCH v2 4/10] Tilera (and Linux asm-generic) support for glibc

[Chris Metcalf <cmetcalf at tilera dot com>]

On 11/11/2011 12:57 PM, Roland McGrath wrote:
>> 2011-11-03  Chris Metcalf  <cmetcalf@tilera.com>
>>
>>   * sysdeps/unix/sysv/linux/epoll_pwait.c (epoll_pwait): Provide an
>>   internal __epoll_pwait() name to avoid the PLT for the epoll_wait()
>>   implementation in the generic Linux ABI port.
> You can do this with libc_hidden instead.  That's the right thing to use
> when PLT avoidance is the issue.  __ names are for when name space
> cleanliness is the issue, which is not the case here.

Thanks.  Here's the revised version of the patch.

2011-11-03  Chris Metcalf  <cmetcalf@tilera.com>

	* sysdeps/unix/sysv/linux/epoll_pwait.c (epoll_pwait): Provide
	an internal name to avoid the PLT for the epoll_wait()
	implementation in the generic Linux ABI port.

diff --git a/sysdeps/unix/sysv/linux/epoll_pwait.c b/sysdeps/unix/sysv/linux/epoll_pwait.c
index e689073..9f72d18 100644
--- a/sysdeps/unix/sysv/linux/epoll_pwait.c
+++ b/sysdeps/unix/sysv/linux/epoll_pwait.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2007 Free Software Foundation, Inc.
+/* Copyright (C) 2007, 2011 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -24,6 +24,8 @@
 #include <sysdep-cancel.h>
 #include <sys/syscall.h>
 
+libc_hidden_proto (epoll_pwait)
+
 #ifdef __NR_epoll_pwait
 
 /* Wait for events on an epoll instance "epfd". Returns the number of
@@ -67,3 +69,5 @@ stub_warning (epoll_pwait)
 
 # include <stub-tag.h>
 #endif
+
+libc_hidden_def (epoll_pwait)

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com