This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Accidental checkin?

On Tue, Dec 14, 2010 at 7:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Dec 14, 2010 at 5:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Hi,
>>
>> Commit 42acbb92c861e97a6e1293ea853db88342a1bf53:
>>
>> http://sourceware.org/git/?p=glibc.git;a=commit;h=42acbb92c861e97a6e1293ea853db88342a1bf53
>>
>> changed
>>
>> sysdeps/i386/i686/multiarch/strcmp.S
>>
>> without ChangeLog entry. ?Is that an accidental checkin?
>>
>
> This change caused:
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=12318
>

That change has a typo.


-- 
H.J.
---
diff --git a/sysdeps/i386/i686/multiarch/strcmp.S
b/sysdeps/i386/i686/multiarch/strcmp.S
index 8724594..b08fd08 100644
--- a/sysdeps/i386/i686/multiarch/strcmp.S
+++ b/sysdeps/i386/i686/multiarch/strcmp.S
@@ -64,7 +64,7 @@ ENTRY(STRCMP)
 	leal	__STRCMP_SSSE3@GOTOFF(%edx), %eax
 	testl	$bit_SSSE3, CPUID_OFFSET+index_SSSE3+__cpu_features@GOTOFF(%edx)
 	jnz	2f
-	leal	__STRCMP_IA32@GOTOFF(%edx), %ecx
+	leal	__STRCMP_IA32@GOTOFF(%edx), %eax
 2:	ret
 END(STRCMP)
 # else
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]