This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390: Fix 31/64 bit utmp compat problem
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
- Cc: libc-alpha at sources dot redhat dot com, schwidefsky at de dot ibm dot com
- Date: Thu, 24 Apr 2008 07:31:14 -0700
- Subject: Re: [PATCH] S/390: Fix 31/64 bit utmp compat problem
- References: <20080424105925.GA9450@homer.boeblingen.de.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Krebbel wrote:
> I've tested the patch on s390 and s390x using the libc testsuite. A
> small 64bit utmp testcase linked against an older libc version runs
> fine with the new version using the compat functions.
Yes, it shows you put a lot of quality testing into the patch. Have you
even reviewed it? All the garbage you sent?
Plus: you don't modify generic code. The only change allowed is perhaps
something like
+#ifndef updwtmp
weak_alias (__updwtmp, updwtmp)
+endif
Everything else must be handle in arch-specific files.
> Ok to apply?
What do you mean by that? You wouldn't apply the patch anyway.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFIEJmy2ijCOnn/RHQRAgb1AJ9u2ZBxtWtTHWH4YHkuaL0lhOcR4gCfTZqq
CpZKlHJneS/w1a1Q/4xP6UE=
=PKDv
-----END PGP SIGNATURE-----