Re: [PATCH] glibc 2.7 compilation failure with GCC 4.2.x due to 486+-specific memmove() redeclaration and _FORTIFY_SOURCEry

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 30 October 2007, Greg Schafer wrote:
> On Sun, Oct 21, 2007 at 11:50:10PM +0100, Nix wrote:
> > Compilation of glibc 2.7 with GCC 4.2.x fails with this error:
> >
> > loki 14 /usr/packages/glibc/libc-patched/debug% gcc warning-nop.c -c
> > -std=gnu99 -fgnu89-inline -O2 -Wall -Winline -Wwrite-strings
> > -fmerge-all-constants -march=native -pipe -Wstrict-prototypes
> > -mpreferred-stack-boundary=2  -g0 -O2 -fomit-frame-pointer
> > -D__USE_STRING_INLINES    -I../include
> > -I/usr/packages/glibc/i686-esperi/debug -I/usr/packages/glibc/i686-esperi
> > -I../sysdeps/i386/elf -I../nptl/sysdeps/unix/sysv/linux/i386/i686
> > -I../nptl/sysdeps/unix/sysv/linux/i386 -I../sysdeps/unix/sysv/linux/i386
> > -I../nptl/sysdeps/unix/sysv/linux -I../nptl/sysdeps/pthread
> > -I../sysdeps/pthread -I../sysdeps/unix/sysv/linux -I../sysdeps/gnu
> > -I../sysdeps/unix/common -I../sysdeps/unix/mman -I../sysdeps/unix/inet
> > -I../sysdeps/unix/sysv/i386 -I../nptl/sysdeps/unix/sysv
> > -I../sysdeps/unix/sysv -I../sysdeps/unix/i386 -I../nptl/sysdeps/unix
> > -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/i386/i686/fpu
> > -I../nptl/sysdeps/i386/i686 -I../sysdeps/i386/i686 -I../sysdeps/i386/i486
> > -I../nptl/sysdeps/i386/i486 -I../sysdeps/i386/fpu -I../nptl/sysdeps/i386
> > -I../sysdeps/i386 -I../sysdeps/wordsize-32 -I../sysdeps/ieee754/ldbl-96
> > -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32
> > -I../sysdeps/ieee754 -I../sysdeps/generic/elf -I../sysdeps/generic
> > -I../nptl  -I.. -I../libio -I. -I
> > /lib/modules/2.6.23.1-skas3-v9-pre9/build/include -D_LIBC_REENTRANT
> > -include ../include/libc-symbols.h       -o
> > /usr/packages/glibc/i686-esperi/debug/warning-nop.o -MD -MP -MF
> > /usr/packages/glibc/i686-esperi/debug/warning-nop.o.dt -MT
> > /usr/packages/glibc/i686-esperi/debug/warning-nop.o In file included from
> > ../include/bits/string3.h:1,
> >                  from ../string/string.h:428,
> >                  from ../include/string.h:49,
> >                  from warning-nop.c:53:
> > ../string/bits/string3.h:58: error: redefinition of ?memmove?
> > ../string/string.h:59: warning: ?memset? declared inline after being
> > called
> >
> > The cause of the error is quite obvious: memmove() is declared in
> > string/string.h as
>
> Umm, it appears you built Glibc with `--enable-omitfp' which is why it
> doesn't fail for everyone. `-D__USE_STRING_INLINES' is the giveaway.
>
> Not sure whether `--enable-omitfp' is a valid config these days...

i'm certainly not going to weigh in on that discussion ;), but from my stance, 
if it's in ./configure, then it's valid and should be fixed ... or punted 
completely
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.