This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: contribution to glibc

Hi,

in addition to my previous comments:

On Friday 16 June 2006 10:54, Rene Rebe wrote:

> most people prefer to look on unified diffs (diff -u) these days. Maybe
> resend it to get more comments and probably also change a subject
> reflecting the content of the contribution e.g. [PATCH] qsort optimization

This change could never have compiled:

<       if (size / pagesize > (size_t) phys_pages)
---
>       if (size / pagesize) > (size_t) phys_pages)

Without reading any further I wonder if you actually tested and benchmarked
the changed you did.

Yours,

-- 
René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany)
            http://exactcode.de | http://t2-project.org | http://rebe.name
            +49 (0)30 / 255 897 45
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]