This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: call for assistance: please test 2.3 branch

On Sun, Oct 23, 2005 at 09:16:08PM -0700, Roland McGrath wrote:
> I am just about ready to release 2.3.6 now.  But I haven't heard much in
> the way of clear feedback about testing the glibc-2_3-branch code.  For my
> part, I've made a new testing update for Fedora Core 3, which should filter
> through to the Fedora distribution sites in the next day or two.  (This is
> from fedora-2_3-branch, which is tracking glibc-2_3-branch.)
> Please test the current 2.3 branch code and post here about your results.
> As in the Fedora case, results of your versions with additional patches are
> also useful, especially if you have merged in the latest 2.3 branch
> contents quite recently.

I think sysdeps/unix/sysv/linux/x86_64/sem_trywait.S in 2.3 and trunk
has some typos. We are doing

 .globl sem_trywait
 .type sem_trywait,@function
 .align 16


 .size sem_trywait,.-sem_trywait
 .weak sem_trywait ; sem_trywait = __new_sem_trywait

I don't think that is what we want. Here is the patch.

2005-10-24  H.J. Lu  <>

	* sysdeps/unix/sysv/linux/x86_64/sem_trywait.S: Fix typo.

--- nptl/sysdeps/unix/sysv/linux/x86_64/sem_trywait.S.undef	2003-05-10 13:37:38.000000000 -0700
+++ nptl/sysdeps/unix/sysv/linux/x86_64/sem_trywait.S	2005-10-24 13:26:37.000000000 -0700
@@ -29,10 +29,10 @@
-	.globl	sem_trywait
-	.type	sem_trywait,@function
+	.globl	__new_sem_trywait
+	.type	__new_sem_trywait,@function
 	.align	16
 	movl	(%rdi), %eax
 2:	testl	%eax, %eax
 	jz	1f
@@ -55,5 +55,5 @@ sem_trywait:
 	orl	$-1, %eax
-	.size	sem_trywait,.-sem_trywait
+	.size	__new_sem_trywait,.-__new_sem_trywait
 	versioned_symbol(libpthread, __new_sem_trywait, sem_trywait, GLIBC_2_1)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]