This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: Add unwind information to i386 LinuxThreads syscalls
On Fri, Feb 25, 2005 at 04:47:57PM -0800, Roland McGrath wrote:
> > On Fri, Feb 25, 2005 at 10:40:55PM +0100, Jakub Jelinek wrote:
> > > On Fri, Feb 25, 2005 at 04:36:55PM -0500, Daniel Jacobowitz wrote:
> > > > LinuxThreads doesn't need unwind information for cancellation, but other
> > > > things need to unwind out of cancellable syscalls from time to time - for
> > > > instance, GDB. I don't know if gcj needs this too but I suspect it does.
> > > > This patch adapts the .eh_frame information from the NPTL version of
> > > > sysdep-cancel.h.
> > > >
> > > > Tested on i686-pc-linux-gnu. Is this OK?
> > >
> > > Can't you use .cfi_* directives instead?
> >
> > Sure, but I didn't write this from scratch - as I said, I took it from
> > the NPTL implementation. Might as well keep them in sync.
>
> Since you've adjusted the bits, they aren't in synch anyway. That code was
> done before .cfi_* were available in the assembler, and just hasn't change
> since. We do not want to add anything new that use hand-written bits.
Actually, I didn't adjust them at all. They're exactly the same as
they are in NPTL. However, if you'd prefer I rewrite them using
.cfi_*, I'll try to do that tomorrow - should be reasonably easy.
--
Daniel Jacobowitz
CodeSourcery, LLC